-
-
Notifications
You must be signed in to change notification settings - Fork 963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adjust defaultBenchmarkDotNetVersion on build #1879
adjust defaultBenchmarkDotNetVersion on build #1879
Conversation
43cdcbf
to
5ec4deb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR (and sorry for the late review). In general, I like this approach, we can try to use it. Once the review comments are resolved, I will merge this PR.
InputFilename="templates/BenchmarkDotNet.BenchmarkProjectTemplate.CSharp/.template.config/template.json" | ||
OutputFilename="templates/BenchmarkDotNet.BenchmarkProjectTemplate.CSharp/.template.config/template.json" | ||
MatchExpression='("defaultValue": )"([\d+\.?]+)"' | ||
ReplacementText='${1}"$(Major).$(Minor).$(Revision)"' /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the recent changes, we should use $(VersionPrefix)
instead of $(Major).$(Minor).$(Revision)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed at c6bd682
OutputFilename="templates/BenchmarkDotNet.BenchmarkProjectTemplate.CSharp/.template.config/template.json" | ||
MatchExpression='("defaultValue": )"([\d+\.?]+)"' | ||
ReplacementText='${1}"$(Major).$(Minor).$(Revision)"' /> | ||
<PropertyGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that we don't actually need this PropertyGroup: all the arguments are defined in attributes of ReplaceFileText
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed at 4f7eac2
disregard this. It will not work due to dotnet/msbuild#5737 |
@askazakov thanks! |
Some automatization to reconcile BenchmarkDotNet version with default version in template
If it's good enough I will fix templates for VB and F# also. If not just close PR