[wasm] Set the right runtime moniker #1932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix dotnet/performance#2250 Commit 80f45ce started using the runtime moniker to decide, which main JS file to use. We use `test-main.js` in net7.0, while we were using `main.js` in older versions. To make that work, let set the right runtime moniker to WasmRuntime. So that later in `Executor::ProcessStartInfo` we select the right file.
Member
adamsitnik
approved these changes
Mar 2, 2022
Member
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, thank you @radekdoulik !
| default: | ||
| return false; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
in the future we might want to move it to RuntimeMonikerExtensions
|
Looks good to me. |
Member
Author
|
The Is that new fail? From quick look it seems unrelated. |
Member
Author
|
Actually I see it fail elsewhere too, so it is not related to this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix dotnet/performance#2250
Commit 80f45ce started using the runtime moniker to decide, which
main JS file to use. We use
test-main.jsin net7.0, while we wereusing
main.jsin older versions.To make that work, let set the right runtime moniker to
WasmRuntime. Sothat later in
Executor::ProcessStartInfowe select the right file.