Fix netcoreapp3.0 and older builds #2352
Conversation
timcassell
force-pushed
the
fix-netcoreapp3.0
branch
2 times, most recently
from
937e3ff
to
ecaff2c
Compare
timcassell
force-pushed
the
fix-netcoreapp3.0
branch
from
e73416a
to
4e3d561
Compare
timcassell
force-pushed
the
fix-netcoreapp3.0
branch
from
4e3d561
to
de3df4e
Compare
|
@AndreyAkinshin May need to update permissions for that report workflow to succeed. actions/first-interaction#10 (comment) |
|
@timcassell permissions for build.yaml are already set: https://github.com/dotnet/BenchmarkDotNet/blob/master/.github/workflows/build.yaml#L7 |
|
Hm, then I'm not sure why it's failing with |
There was a problem hiding this comment.
It LGTM, please feel free to mark it as ready and then I am going to simply merge it.
thank you @timcassell !
| <PackageReference Include="System.Management" Version="5.0.0" /> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.2.0" /> | ||
| </ItemGroup> | ||
| <ItemGroup Condition=" '$(TargetFramework)' == 'net6.0' "> |
There was a problem hiding this comment.
nit: in the future we might add net7.0, net8.0 and other targets, so we could just change the condition to "everything that is not .NET Standard 2.0"
| <ItemGroup Condition=" '$(TargetFramework)' == 'net6.0' "> | |
| <ItemGroup Condition=" '$(TargetFramework)' != 'netstandard2.0' "> |
There was a problem hiding this comment.
I'd rather be explicit about that since updating the nuget packages in the future could also break net6.0 etc when their support is dropped.
There was a problem hiding this comment.
I'd rather be explicit about that since updating the nuget packages in the future could also break net6.0 etc when their support is dropped.
Good point!
| <PackageReference Include="System.Management" Version="5.0.0" /> | ||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.2.0" /> | ||
| </ItemGroup> | ||
| <ItemGroup Condition=" '$(TargetFramework)' == 'net6.0' "> |
There was a problem hiding this comment.
I'd rather be explicit about that since updating the nuget packages in the future could also break net6.0 etc when their support is dropped.
Good point!
Fixes #2333