Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wasm and MonoAOTLLVM to DotNetSdkVersionValidator #2541

Merged

Conversation

LoopedBard3
Copy link
Member

Add Wasm and MonoAOTLLVM plain moniker support to DotNetSdkVersionValidator. I used the same check mentioned in the issue for determining the sdkversion, with an additional substring to remove the 'net' portion of the MsBuildMoniker (eg. net9.0).
Tested locally for MonoAOTLLVM successfully.

Fix: #2540

@timcassell
Copy link
Collaborator

timcassell commented Mar 8, 2024

I think we should use the version of the runtime rather than the MsBuildMoniker. CoreRuntime.TryGetVersion That way we can be sure we're not getting something like net8.0-windows or netcoreapp3.1 and we can make sure it's using a supported version (3.1 should be bumped up to 5.0/6.0). Now that I mention it, the config parser doesn't enforce the minimum version there either, so it would probably just explode if the host version is too old (do we care, though?).

@LoopedBard3
Copy link
Member Author

Updated and tested locally for MonoAOTLLVM successfully.

@timcassell timcassell merged commit 036f466 into dotnet:master Mar 10, 2024
8 checks passed
@timcassell timcassell added this to the v0.14.0 milestone Mar 10, 2024
@LoopedBard3 LoopedBard3 deleted the FixMonoAOTLLVMSdkVersionFromMoniker branch March 10, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use wasm or monoaotllvm as runtime
3 participants