Skip to content

Fix EtwProfiler for file paths slightly under 260 chars #2808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025
Merged

Fix EtwProfiler for file paths slightly under 260 chars #2808

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/BenchmarkDotNet/Helpers/ArtifactFileNameHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ internal static class ArtifactFileNameHelper

internal static string GetTraceFilePath(DiagnoserActionParameters details, DateTime creationTime, string fileExtension)
{
return GetFilePath(details, null, creationTime, fileExtension, "userheap.etl".Length);
return GetFilePath(details, null, creationTime, fileExtension, "userheap.etl".Length - fileExtension.Length);
}

internal static string GetFilePath(DiagnoserActionParameters details, string? subfolder, DateTime? creationTime, string fileExtension, int reserve)
Expand All @@ -27,7 +27,7 @@ internal static string GetFilePath(DiagnoserActionParameters details, string? su

// long paths can be enabled on Windows but it does not mean that everything is going to work fine..
// so we always use 260 as limit on Windows
int limit = OsDetector.IsWindows()
int limit = OsDetector.IsWindows()
? WindowsOldPathLimit - reserve
: CommonSenseLimit;

Expand Down