Skip to content

Deprecate WithNuget #2812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2025
Merged

Deprecate WithNuget #2812

merged 2 commits into from
Jul 22, 2025

Conversation

@timcassell
Copy link
Collaborator

@timcassell timcassell commented Jul 21, 2025 •
edited
Loading

The feature cannot be supported for dotnet run app.cs (#2754), and complicates things like #2508.
Better to deprecate it for the next patch version, then remove it later in the next minor version.
The feature has been fully subsumed by the much more powerful MsBuildArguments (the only downside is user's csproj will have more lines).

Added Job.WithMsBuildArguments extension to simplify usage.

@timcassell
Deprecated .WithNuget.
908b579 
Added .WithMsBuildArguments.
Updated IntroNuGet.
@timcassell timcassell added this to the v0.15.3 milestone Jul 21, 2025
adamsitnik
adamsitnik approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The feature cannot be supported for dotnet run app.cs (#2754)

I am fine with that. The fact that some of our users want to do something fancy does not mean that features used by other users should stop working.

complicates things like #2508

I agree. Since what you have provided in the docs is simpler to use and reliable I am fine with that direction. Thank you @timcassell !

@timcassell timcassell merged commit a9cd780 into master Jul 22, 2025
22 of 23 checks passed
@timcassell timcassell deleted the deprecate-withnuget branch July 22, 2025 18:09
This was referenced Sep 17, 2025
Closed
Closed
Closed
Merged
Merged
Merged
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Merged
Merged
Closed
Closed
Merged
Closed
Merged
@dependabot dependabot bot mentioned this pull request Nov 16, 2025
Open
agocke pushed a commit to serdedotnet/serde.cmdline that referenced this pull request Nov 16, 2025
@dependabot
Bump BenchmarkDotNet from 0.14.0 to 0.15.6 (#9)
835e0e3 
Updated [BenchmarkDotNet](https://github.com/dotnet/BenchmarkDotNet)
from 0.14.0 to 0.15.6.

<details>
<summary>Release notes</summary>

_Sourced from [BenchmarkDotNet's
releases](https://github.com/dotnet/BenchmarkDotNet/releases)._

## 0.15.6

Full changelog: https://benchmarkdotnet.org/changelog/v0.15.6.html


## 0.15.5

Full changelog: https://benchmarkdotnet.org/changelog/v0.15.5.html



## 0.15.4

Full changelog: https://benchmarkdotnet.org/changelog/v0.15.4.html

## Highlights

Allow override method/property for ParamsSource
([#​2832](dotnet/BenchmarkDotNet#2832))


## 0.15.3

Full changelog: https://benchmarkdotnet.org/changelog/v0.15.3.html

## Highlights

Improvements:

- Naot instruction set support for .NET 10+, migrate to ISA groupings in
CPU summary
[#​2828](dotnet/BenchmarkDotNet#2828)
- Support benchmark filtering for TestAdapter
[#​2662](dotnet/BenchmarkDotNet#2662)
[#​2788](dotnet/BenchmarkDotNet#2788)
- Support non-primitive external types in `ArgumentsSource`
[#​2820](dotnet/BenchmarkDotNet#2820)
- Enable MSBuild parallel build via `--nodeReuse:false`
[#​2693](dotnet/BenchmarkDotNet#2693)
[#​2814](dotnet/BenchmarkDotNet#2814)
- Improve CPU detection
[#​2747](dotnet/BenchmarkDotNet#2747)
[#​2749](dotnet/BenchmarkDotNet#2749)
- Enable assembly signing for debug build
[#​2774](dotnet/BenchmarkDotNet#2774)

Deprecations:

- Deprecated `WithNuget`
[#​2812](dotnet/BenchmarkDotNet#2812)

Bug fixes:

- Fix `InvalidOperationException` in diagnosers
[#​2758](dotnet/BenchmarkDotNet#2758)
[#​2805](dotnet/BenchmarkDotNet#2805)
- Fix file detection in `NativeMemoryProfiler`
[#​2794](dotnet/BenchmarkDotNet#2794)
[#​2795](dotnet/BenchmarkDotNet#2795)
- Fix long file paths issue in `EtwProfiler`
[#​2807](dotnet/BenchmarkDotNet#2807)
[#​2808](dotnet/BenchmarkDotNet#2808)
- Fix log duplications in TestAdapter
[#​2790](dotnet/BenchmarkDotNet#2790)
- Fix x86 disassembler error for net462
[#​2792](dotnet/BenchmarkDotNet#2792)
- Fix `IsNetCore` and `IsNativeAOT` for single-file apps without AOT
[#​2799](dotnet/BenchmarkDotNet#2799)
- Fix density plot generation in `RPlotExporter` for latest version of R
[#​2809](dotnet/BenchmarkDotNet#2809)


## 0.15.2

Full changelog: https://benchmarkdotnet.org/changelog/v0.15.2.html

## Highlights

- The most significant update in this release is the enhanced accuracy
of the memory diagnoser
([#​2562](dotnet/BenchmarkDotNet#2562)). This
improvement resolves the issue of incorrectly reported memory
allocations
([#​1542](dotnet/BenchmarkDotNet#1542),
[#​2582](dotnet/BenchmarkDotNet#2582)).
- We have introduced a new feature that allows users to sort benchmark
jobs in numerical order
([#​2768](dotnet/BenchmarkDotNet#2768),
[#​2770](dotnet/BenchmarkDotNet#2770)).
- Benchmark validation has been improved
([#​2771](dotnet/BenchmarkDotNet#2771)).
- An issue with non-persistent auto-generated JobId has been fixed
([#​2777](dotnet/BenchmarkDotNet#2777)).


## 0.15.1

Full changelog: https://benchmarkdotnet.org/changelog/v0.15.1.html

## Highlights

- Added support for *.slnx
([#​2763](dotnet/BenchmarkDotNet#2763),
[#​2764](dotnet/BenchmarkDotNet#2764))
- Enabled ArgumentsSource to reference methods in other types
([#​2744](dotnet/BenchmarkDotNet#2744),
[#​2748](dotnet/BenchmarkDotNet#2748))
- Resolved fatal errors for ARM CPUs
([#​2745](dotnet/BenchmarkDotNet#2745),
[#​2756](dotnet/BenchmarkDotNet#2756))
- Fixed bugs related to support for Android, browser, iOS, and tvOS
([#​2739](dotnet/BenchmarkDotNet#2739),
[#​2741](dotnet/BenchmarkDotNet#2741),
[#​2740](dotnet/BenchmarkDotNet#2740),
[#​2742](dotnet/BenchmarkDotNet#2742))



## 0.15.0

Full changelog: https://benchmarkdotnet.org/changelog/v0.15.0.html



Commits viewable in [compare
view](dotnet/BenchmarkDotNet@v0.14.0...v0.15.6).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=BenchmarkDotNet&package-manager=nuget&previous-version=0.14.0&new-version=0.15.6)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Nov 17, 2025
Open
Merged
Open
Closed
Closed
Open
Closed
Open
Open
Closed
Open
Open
Closed
Open
Open
Merged
Open
Open
Open
Open
Merged
This was referenced Nov 24, 2025
Open
Merged
Merged
Open
Merged
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamsitnik adamsitnik adamsitnik approved these changes

Assignees

No one assigned

Labels

Area:Documentation

Projects

None yet

Milestone

v0.15.3

Development

Successfully merging this pull request may close these issues.

3 participants

@timcassell @adamsitnik