Extended the support for ClangSharp via libClangSharp #159
Conversation
sources/libClangSharp/ClangSharp.h
Outdated
| @@ -12,7 +14,7 @@ | |||
| #endif | |||
|
|
|||
| #ifdef _MSC_VER | |||
| #ifdef CLANGSHARP_LINKAGE | |||
| #ifdef clangsharp_LINKAGE | |||
There was a problem hiding this comment.
Shouldn't this be libClangSharp_EXPORTS?
(libClangSharp because that's what it's called on Windows builds and this is for Windows.
Better yet, can we just add our own preprocessor define instead of relying on the magic one added by CMake?
There was a problem hiding this comment.
no, libclang just uses CLANG_LINKAGE
There was a problem hiding this comment.
I'm slightly confused now. Pretty sure libclang uses CINDEX_LINKAGE and that's not what this review comment is referring to.
I see you changed it back to #ifdef CLANGSHARP_LINKAGE, but I don't think that's right either.
#ifdef CLANGSHARP_LINKAGE
#define CLANGSHARP_LINKAGE EXTERN_C __declspec(dllexport)
#else
#define CLANGSHARP_LINKAGE EXTERN_C __declspec(dllimport)
#endifThis can only ever do two things:
CLANGSHARP_LINKAGEwill be defined twice, causing an C4005 warning.CLANGSHARP_LINKAGEwill defined asEXTERN_C __declspec(dllimport)(which isn't right when we're building a DLL.)
I feel like I'm missing something here since it shouldn't even build without CLANGSHARP_LINKAGE (and even with it defined there'll be a warning.) Maybe I'm blind, but it doesn't look like libClangSharp is even built by the build scripts at all. Are you just manually invoking cmake and creating the NuGet package for it manually?
There was a problem hiding this comment.
It looks to be "working" because CLANGSHARP_LINKAGE isn't defined and therefore it is always exported.
Edit: Got this reversed, but in any case, MSVC is still correctly exporting the symbols and things work, so it isn't really an issue.
It ultimately doesn't matter because no one is going to use this from C code anyways, so most of it doesn't apply.
I will, however, fix it to just always export with a note that no one should be using this from another C library.
The libClang bindings are very limited in what they expose and libClangSharp exists to help bridge that gap.
This expands libClangSharp to support quite a bit of additional functionality so the much of the guesswork no longer has to occur. Namely, the majority of the core properties on the C and C++ decls, statements, and expressions now have a way to directly query the relevant information. ObjC, OMP, and various Clang specific builtins do not currently have such support nor is absolutely everything exposed. However, this should make traversal of more complex ASTs easier and less error prone. It should also help with processing information out of the various template types.