Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to use the new fnptr syntax and fixing a couple minor issues #174

Merged
merged 5 commits into from
Sep 16, 2020

Conversation

tannergooding
Copy link
Member

The alignment and callexpr issues were found when processing libX11 and libVulkan.

@tannergooding tannergooding merged commit 398e9c5 into dotnet:master Sep 16, 2020
@sotteson1
Copy link
Contributor

I'm wondering about this change:

            _outputBuilder.WriteIndented("[UnmanagedFunctionPointer");

            if (callingConventionName != "Winapi")
            {
                _outputBuilder.Write("(CallingConvention.");
                _outputBuilder.Write(callingConventionName);
                _outputBuilder.Write(')');
            }

            _outputBuilder.WriteLine(']');

That attribute seems to only have one constructor that takes the calling convention, but it's left out if the calling convention isn't Winapi. I'm sure I'm missing something, but I don't see how this should work if the calling convention is Winapi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants