Fix crash when using a default argument from a base template #547
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if
ParamVarDecl::hasDefaultArg
returnstrue
, the default argument can be one of three kinds: normal, unparsed and uninstantiated. Each of these kinds needs to be handled differently:getDefaultArg
getUninstantiatedDefaultArg
This change handles all three kinds and centralizes the checks for and calls to get default args to a single location per method.