Setup some infrastructure for the repository. #60
Conversation
| # suggest static readonly declarations be pascal case | ||
| # suggest type parameters be prefixed with T | ||
| ############################################################################### | ||
| [*.cs] |
There was a problem hiding this comment.
These all match the VS defaults modulo csharp_indent_case_contents_when_block
| csharp_indent_block_contents = true | ||
| csharp_indent_braces = false | ||
| csharp_indent_case_contents = true | ||
| csharp_indent_case_contents_when_block = false |
There was a problem hiding this comment.
This is the only new option that differs from the VS default. The VS default is true for compatibility reasons. This option is used in combination with csharp_indent_case_contents and you have effectively the following combinations:
(VS Default) csharp_indent_case_contents=true, csharp_indent_case_contents_when_block=true:
switch (value)
{
case 1:
break;
case 2:
{
break;
}
}csharp_indent_case_contents=false, csharp_indent_case_contents_when_block=true:
switch (value)
{
case 1:
break;
case 2:
{
break;
}
}csharp_indent_case_contents=false, csharp_indent_case_contents_when_block=false:
switch (value)
{
case 1:
break;
case 2:
{
break;
}
}(The one I chose) csharp_indent_case_contents=true, csharp_indent_case_contents_when_block=false:
switch (value)
{
case 1:
break;
case 2:
{
break;
}
}
There was a problem hiding this comment.
I personally don't like the corefx style, but since you've written most of the code here now you can pick whatever you want.
There was a problem hiding this comment.
Which one of the four is your preference? I don't feel particularly strongly as long as the editorconfig ensures it is automatically normalized.
There was a problem hiding this comment.
The last one seems ok. I don't know why it's not the default. The VS Default looks ugly.
There was a problem hiding this comment.
The last one is the one I already choose for the repo (and was the one I thought you were indicating you didn't like) 😄
The first is the VS default for compatibility reasons at this point. The option allowing the last setup was only introduced a couple versions ago (I think VS2015 or 2017) and hasn't been around for very long at this point.
| *.suo | ||
| *.user | ||
| *.sln.docstates | ||
| ############################################################################### |
There was a problem hiding this comment.
The main .gitignore file has a lot more than necessary. I can keep it if desired, but I personally find the smaller subset easier to reason about.
There was a problem hiding this comment.
(It also helps expose places where things aren't ending up where expected as almost all excluded files should end up under artifacts).
There was a problem hiding this comment.
I agree ... I just let GitHub decide so this is better imo too.
| @@ -0,0 +1,73 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <Project> | |||
There was a problem hiding this comment.
Centralized basically all of the relevant project settings here.
| </ItemGroup> | ||
|
|
||
| <!-- Package versions for package references across all projects --> | ||
| <ItemGroup> |
There was a problem hiding this comment.
Package versions are centrally managed here.
|
What do you mean by existing AzDO repo? Do we need a repo? I thought we just need an instance. |
|
Right, I meant instance. Something like you have for the LLVMSharp repo. |
|
Ok ... I'd love if it could be in dnceng . |
I've pinged the e-mail thread to see what is recommended here. |
This sets up a lot of infrastructure for the repository including using Directory.Build.props/targets and adding various scripts for building, restoring, testing, and packing.
I believe the ultimate end-goal is to get on dotnet/arcade, but this should still be a step in the right direction.
It does not currently enable strong-name signing (as it needs to be determined if a custom or existing strong name key will be used). It would also be trivial to hook up authenticode signing once that is resolved.
If we have an existing AzDO repo, I can also add the
azure-pipelines.ymlfile and get that enabled.