Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo cleanup #58

Closed
wants to merge 80 commits into from
Closed

typo cleanup #58

wants to merge 80 commits into from

Conversation

nschonni
Copy link

@nschonni nschonni commented Jun 28, 2019

I did this as a large batch, but I can submit the commits separately if preferred

@nschonni nschonni changed the title typo: System.string -> System.String typo cleanup Jun 28, 2019
@divega
Copy link
Contributor

divega commented Jun 29, 2019

@nschonni I really appreciate you effort here. So many typos! Unfortunately API documentation contents on this repo are automatically generated from the source code in the product repos, and the changes need to happen at the source. Please check the readme file.

Cc @mairaw, @dendeli-msft, in case you are aware of any tooling that could merge these changes into the corresponding source.

@nschonni
Copy link
Author

No problem, I thought it was like the dotnet-api-docs. I can see if I can backport them as well

@mairaw
Copy link
Contributor

mairaw commented Jul 1, 2019

dotnet-api-docs is a bit of an exception when it comes to the .NET Core SDKs.
Perhaps @nschonni can run the same tool on the source?

@divega
Copy link
Contributor

divega commented Jul 1, 2019

I am going to go ahead and close this PR here. Thanks for submitting the PRs to the product repos.

@divega divega closed this Jul 1, 2019
@nschonni nschonni deleted the typos branch July 1, 2019 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants