Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should mention the necessity of a value comparer #2824

Closed
IndigoHealth opened this issue Nov 1, 2020 · 0 comments · Fixed by #3020
Closed

Should mention the necessity of a value comparer #2824

IndigoHealth opened this issue Nov 1, 2020 · 0 comments · Fixed by #3020

Comments

@IndigoHealth
Copy link

Many developers will read this (excellent) writeup on value converters, and not realize the necessity of a related value comparer. You really need a section that warns readers that creating a value converter often requires an associated value comparer, with a sentence or two explaining, at a high level, under what conditions a value comparer is necessary, and giving a link to the page on value converters.


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@ajcvickers ajcvickers self-assigned this Nov 2, 2020
@ajcvickers ajcvickers added this to the 5.0.0 milestone Nov 2, 2020
ajcvickers added a commit that referenced this issue Jan 17, 2021
Lots of examples!

Fixes #614
Fixes #784
Part of #685
Fixes #2252
Fixes #2415
Fixes #2456
Fixes #2824
Fixes #2979
ajcvickers added a commit that referenced this issue Jan 17, 2021
Lots of examples!

Fixes #614
Fixes #784
Part of #685
Fixes #2252
Fixes #2415
Fixes #2456
Fixes #2824
Fixes #2979
ajcvickers added a commit that referenced this issue Jan 17, 2021
Lots of examples!

Fixes #614
Fixes #784
Part of #685
Fixes #2252
Fixes #2415
Fixes #2456
Fixes #2824
Fixes #2979
ajcvickers added a commit that referenced this issue Jan 19, 2021
Lots of examples!

Fixes #614
Fixes #784
Part of #685
Fixes #2252
Fixes #2415
Fixes #2456
Fixes #2824
Fixes #2979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants