Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge repeated sections #2980

Closed
AndriySvyryd opened this issue Jan 5, 2021 · 1 comment · Fixed by #2998
Closed

Merge repeated sections #2980

AndriySvyryd opened this issue Jan 5, 2021 · 1 comment · Fixed by #2998
Assignees
@roji
Labels
area-value-generation
Milestone
6.0.0

Comments

@AndriySvyryd
Copy link
Member

Related: https://github.com/dotnet/EntityFramework.Docs.pl-pl/issues/11

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
@AndriySvyryd AndriySvyryd added this to the 6.0.0 milestone Jan 8, 2021
@roji
Copy link
Member

roji commented Jan 10, 2021

This doesn't seem like a mangled merge conflict - the page seems intentionally structured to first have a "conceptual" section explaining the 3 value generation patterns, and then a "concrete" section for each type (e.g. detailing computed columns specifically for on-add-or-update).

I'll submit a PR to simplify and merge.

roji added a commit that referenced this issue Jan 10, 2021
@roji
Improvements to the value generation page
9bf7100 
Fixes #2980
Fixes #2947
@roji roji mentioned this issue Jan 10, 2021
Merged
roji added a commit that referenced this issue Jan 10, 2021
@roji
Improvements to the value generation page
cc1c70e 
Fixes #2980
Fixes #2947
roji added a commit that referenced this issue Jan 10, 2021
@roji
Improvements to the value generation page
45ae220 
Fixes #2980
Fixes #2947
roji added a commit that referenced this issue Jan 13, 2021
@roji
Improvements to the value generation page
6eec431 
Fixes #2980
Fixes #2947
roji added a commit that referenced this issue Jan 13, 2021
@roji @AndriySvyryd
Improvements to value generation docs (#2998)
5a60b35 
* Improvements to the value generation page
* Create new page on SQL Server value generation, with information
  on IDENTITY, seed/increment, etc.
* Delete "explicit values for generated properties" page, moving
  relevant content to the new SQL Server page and to the fixed-up
  generated properties page.

Fixes #2980
Fixes #2947
Closes #2999

Co-authored-by: Andriy Svyryd <AndriySvyryd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roji roji

Labels
area-value-generation
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Improvements to value generation docs dotnet/EntityFramework.Docs
2 participants
@roji @AndriySvyryd