Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing code snippet on NRT doc #3048

Closed
garyng opened this issue Jan 28, 2021 · 1 comment · Fixed by #3050
Closed

Missing code snippet on NRT doc #3048

garyng opened this issue Jan 28, 2021 · 1 comment · Fixed by #3050
Assignees
Milestone

Comments

@garyng
Copy link
Contributor

garyng commented Jan 28, 2021

https://docs.microsoft.com/en-us/ef/core/miscellaneous/nullable-reference-types#navigating-and-including-nullable-relationships
image


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

@roji
Copy link
Member

roji commented Jan 28, 2021

@smitpatel looks like the doc system stopped handling code snippet links of the form:

[!code-csharp[Main](../../../samples/core/Miscellaneous/NullableReferenceTypes/Program.cs?range=46)]

Curiously, ?range=36-39&highlight=2 (just below) does work - maybe it's the fact that it's a single line (?start=46&end=46 also didn't work). I've converted to named regions for the collations page (#3050) but maybe we should reach out to the docs team...

roji added a commit that referenced this issue Feb 1, 2021
@roji roji self-assigned this Feb 1, 2021
@roji roji added this to the 6.0.0 milestone Feb 1, 2021
@roji roji closed this as completed in #3050 Feb 3, 2021
roji added a commit that referenced this issue Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants