Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammatical error on the Value Conversions page #3650

Closed
metaljase opened this issue Dec 31, 2021 · 1 comment · Fixed by #3651
Closed

Grammatical error on the Value Conversions page #3650

metaljase opened this issue Dec 31, 2021 · 1 comment · Fixed by #3651

Comments

@metaljase
Copy link

I believe I've spotted a grammatical error in the following paragraph in the 'Column facets and mapping hints' section on the Value Conversions page:

Now any time this converter is used, the database column will be non-unicode with a max length of 20. However, these are only hints since they are be overridden by any facets explicitly set on the mapped property.

I suspect "are be overridden" should be "could be overridden"?


Document Details

Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

roji added a commit to roji/EntityFramework.Docs that referenced this issue Dec 31, 2021
@roji
Copy link
Member

roji commented Dec 31, 2021

Thanks @metaljase, I've submitted #3651 to fix this.

@roji roji self-assigned this Dec 31, 2021
@roji roji added this to the 7.0.0 milestone Dec 31, 2021
@roji roji closed this as completed in #3651 Jan 3, 2022
roji added a commit that referenced this issue Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants