Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge default values and computed columns into generated properties #2003

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

roji
Copy link
Member

@roji roji commented Dec 19, 2019

Plus some cleanup.

Part of #1669

PS I plan to work some more on this page, specifically to merge the introductory "patterns" with the configuration section, and to try to make things a bit lighter/terser. But that's for another PR.

@roji roji force-pushed the MergeRelationalGeneratedProps branch from 7717dd4 to 39e93a2 Compare December 19, 2019 15:03
@roji roji marked this pull request as ready for review December 19, 2019 15:12
Copy link
Member

@ajcvickers ajcvickers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is okay for now, but #1398 will need to change it again.

@roji roji force-pushed the MergeRelationalGeneratedProps branch from 39e93a2 to f9adf90 Compare December 20, 2019 12:46
@roji roji merged commit a62fb8e into master Dec 20, 2019
@roji roji deleted the MergeRelationalGeneratedProps branch December 21, 2019 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants