-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make breadcrumbs consistent with .NET and ASP.NET docs #2159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, @scottaddie :-)
@smitpatel @ajcvickers I have a bit more testing to do, but so far everything looks good. Hold off on merging for now. |
@smitpatel @ajcvickers Ready for one last review. You can use the following link to preview the changes: https://review.docs.microsoft.com/ef/core/?branch=pr-en-us-2159 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
A related weird thing. @ajcvickers can define behavior https://review.docs.microsoft.com/en-us/ef/core/miscellaneous/testing/sqlite?branch=pr-en-us-2159 |
@smitpatel The preferred approach is to create an Overview page within the Fundamentals node. That doesn't exist, so I have it link to the Connection Strings doc instead. |
I think it's fine for now. But we should create an Overview page at some point. Filed #2160 |
Fixes #2131
Internal review page
This PR also updates the master ToC by: