Refactor and improve async documentation #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Sep 2, 2020
smitpatel
reviewed
Sep 2, 2020
smitpatel
reviewed
Sep 2, 2020
smitpatel
reviewed
Sep 2, 2020
| Unfortunately, referencing System.Interactive.Async causes ambiguous invocation compilation errors on LINQ operators applied to EF's DbSets; this makes it hard to use both EF and System.Interactive.Async in the same project. To work around this issue, add AsQueryable to your DbSet: | ||
|
|
||
| ```c# | ||
| var groupedHighlyRatedBlogs = await context.Blogs |
There was a problem hiding this comment.
use sample rather than inline code.
There was a problem hiding this comment.
I'd love to, but I can't 🤣
This code sample can't coexist with the simpler one just above in the same project...
There was a problem hiding this comment.
You would need a different project. 😉
|
Did you update the PR? Comments are marked as resolved but I don't see changes. |
|
Sorry, commit got botched somehow... new version up. |
* Merge query and saving async pages * Move under fundamentals * Document ambiguous invocation issues with System.Interactive.Async and show workaround. Closes #1722 Related to #1332 Related to dotnet/efcore#18124
smitpatel
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1722
Related to #1332
Related to dotnet/efcore#18124