Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use colons consistently for connection strings in UserSecrets #3008

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

ajcvickers
Copy link
Contributor

Fixes #2805
Fixes #2995

I think I figured out the continual confusion here. The colon is always correct when reading from ASP.NET config JSON. However, when using UserSecrets, the secret can be stored as either ConnectionString.Foo or ConnectionString:Foo. We showed examples using periods, which then works when looking up with periods. But then this doesn't work for connection strings from configuration, even though the document makes the assumption that these things work the same.

The fix here is to use colons consistently. I also plan to update more of the connection strings documentation at a later time. But many people have hit this, so wanted to fix it now.

Fixes #2805
Fixes #2995

I think I figured out the continual confusion here. The colon is always correct when reading from ASP.NET config JSON. However, when using UserSecrets, the secret can be stored as either `ConnectionString.Foo` or `ConnectionString:Foo`. We showed examples using periods, which then works when looking up with periods. But then this doesn't work for connection strings from configuration, even though the document makes the assumption that these things work the same.

The fix here is to use colons consistently. I also plan to update more of the connection strings documentation at a later time. But many people have hit this, so wanted to fix it now.
@ajcvickers ajcvickers requested a review from a team January 12, 2021 20:13
@ajcvickers ajcvickers merged commit ef7247f into master Jan 15, 2021
@smitpatel smitpatel deleted the ColonicIrrigation0112 branch January 19, 2021 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small error Command listed does not work correctly
3 participants