Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generated-properties.md #3167

Merged
merged 2 commits into from
Mar 21, 2021
Merged

Update generated-properties.md #3167

merged 2 commits into from
Mar 21, 2021

Conversation

Rick-Anderson
Copy link
Contributor

@Rick-Anderson Rick-Anderson commented Mar 21, 2021

Partial address of #3165 until I have time to update the page.

@Rick-Anderson Rick-Anderson requested a review from roji March 21, 2021 03:51
@@ -72,7 +72,7 @@ Similarly, a property can be configured to have its value generated on add or up
>
> For example, on SQL Server, when a GUID property is configured as value generated on add, the provider automatically performs value generation client-side, using an algorithm to generate optimal sequential GUID values. However, specifying `ValueGeneratedOnAdd()` on a DateTime property will have no effect ([see the section below for DateTime value generation](#datetime-value-generation)).
>
> Similarly, byte[] properties that are configured as generated on add or update and marked as concurrency tokens are set up with the rowversion data type, so that values are automatically generated in the database. However, specifying `ValueGeneratedOnAddOrUpdate()` will again have no effect.
> Similarly, byte[] properties that are configured as generated on add or update and marked as concurrency tokens are set up with the rowversion data type, so that values are automatically generated in the database. However, specifying <xref:Microsoft.EntityFrameworkCore.Metadata.Builders.PropertyBuilder.ValueGeneratedOnAdd%2A> has no effect.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make the above ValueGeneratedOnAdd an xref as well

@Rick-Anderson Rick-Anderson requested a review from roji March 21, 2021 17:21
@roji roji merged commit b8f10b4 into main Mar 21, 2021
@roji
Copy link
Member

roji commented Mar 21, 2021

Thanks @Rick-Anderson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants