Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EF6 to EF Core porting guide #3509

Merged
merged 25 commits into from
Dec 17, 2021

Conversation

JeremyLikness
Copy link
Member

A comprehensive guide to porting from EF6 to EF Core. This will address #1180.

Adding that oh-so-important new line at the end to make the linter... happy?
@AndriySvyryd
Copy link
Member

Take a look at #1989 for additional points

@ajcvickers
Copy link
Contributor

Good stuff!

@JeremyLikness JeremyLikness marked this pull request as ready for review December 8, 2021 22:39
@JeremyLikness
Copy link
Member Author

@dotnet/efteam this is in draft status ready for your review.

I'll tag some other individuals after this first round.

@JeremyLikness
Copy link
Member Author

Adding @ryanbrandenburg and @jinujoseph for review and feedback.

@JeremyLikness
Copy link
Member Author

Hi @dotnet/efteam and @ErikEJ ... I made a pass at updates, waiting for an approval or another round of edits. Goal is to get this out early next week. Thanks!

Add note to resolve dotnet#3586.
add missing note directive (!)
@JeremyLikness JeremyLikness linked an issue Dec 10, 2021 that may be closed by this pull request
Fix "complete"
@@ -35,3 +35,5 @@ You may want to consider an alternate workflow and follow steps similar to the [
## Customize the code generation

As of EF Core 6, it is possible to customize the code generated by scaffolding by using [T4 templates](/visualstudio/modeling/code-generation-and-t4-text-templates). See [T4 and EF Core Reverse Engineering](https://www.bricelam.net/2020/02/03/t4-and-efcore.html) for details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"As of EF Core 6, it is possible to customize..." It is currently not possible.

@@ -66,7 +66,7 @@ EF6 supported table-per-hierarchy (TPH), table-per-type (TPT) and table-per-conc

### Attributes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"For spatial support, EF Core recommends using a third-party library such as NetTopologySuite." I would change this to indicate that EF Core integrates with NTS. Using a different third-party library won't work unless this same integration work is done, which is non-trivial. Something like, "For spatial support, EF Core integrates with the third-party community library NetTopologySuite."

Copy link
Contributor

@ajcvickers ajcvickers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@JeremyLikness JeremyLikness merged commit 0c3c4db into dotnet:main Dec 17, 2021
@JeremyLikness JeremyLikness deleted the ef6-to-efcore6-port branch December 17, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a more complete guide to porting from EF6
5 participants