Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Porting comprehensive Cosmos DB sample #3647

Merged
merged 11 commits into from
Feb 17, 2022
Merged

Porting comprehensive Cosmos DB sample #3647

merged 11 commits into from
Feb 17, 2022

Conversation

JeremyLikness
Copy link
Member

Porting docs example from personal repo

@JeremyLikness
Porting comprehensive Cosmos DB sample
03a65d1 
Porting docs example from personal repo
@JeremyLikness
fixes per linter
a5621d7 
trailing spaces and list indentation
@JeremyLikness JeremyLikness requested a review from a team December 29, 2021 19:14
@JeremyLikness
Copy link
Member Author

@ajcvickers and @AndriySvyryd this is a port of the docs sample. How do you want to reference it? After we validate the sample, I'll update whatever docs page makes sense. If you like I can add a new topic under the cosmos provider section that describes and links to the app. Thanks! This addresses #2660.

AndriySvyryd
AndriySvyryd approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@AndriySvyryd AndriySvyryd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Rename the folder under samples to comprehensive or end2end.
We could add a page under Cosmos briefly describing the sample and why Cosmos would be a better fit for this app than a relation database.

@JeremyLikness
Copy link
Member Author

@AndriySvyryd ready for your final review. /cc @dotnet/efteam for anyone else interested.

@JeremyLikness
Copy link
Member Author

This will fix #2660

@JeremyLikness JeremyLikness linked an issue Feb 16, 2022 that may be closed by this pull request
Cosmos: Create a compelling sample #2660
Closed
JeremyLikness and others added 4 commits February 17, 2022 15:45
@JeremyLikness @AndriySvyryd
Update entity-framework/core/providers/cosmos/planetary-docs-sample.md
2735431 
Co-authored-by: Andriy Svyryd <AndriySvyryd@users.noreply.github.com>
@JeremyLikness
Delete .gitignore
ee1dc2c 
not needed
@JeremyLikness
Delete .gitattributes
7b8572e 
also not needed
@JeremyLikness
Update Directory.Build.props
6b651f0 
bump to C# 10.0
@JeremyLikness JeremyLikness merged commit 79547e3 into dotnet:main Feb 17, 2022
@JeremyLikness JeremyLikness deleted the jrl-adds-cosmos-sample branch February 17, 2022 23:52
@roji roji mentioned this pull request Feb 21, 2022
Merged
@roji roji mentioned this pull request Mar 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cosmos: Create a compelling sample
2 participants
@JeremyLikness @AndriySvyryd