Move DbContext Pooling from Miscellaneous TOC to DbContext config #3656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we should leave it in both places? For discoverability. |
|
I guess... I like to leave Miscellaneous as small as possible, and DbContext pooling really is a perf feature. If anything, it should probably be mentioned somewhere under "DbContext Lifetime, Configuration, and Initialization"... |
|
I like putting it under "DbContext configuration and initialization" |
|
I can do that. What do you think, an additional short section in the existing overview page? Because there's only that one page in the section, it would be weird to have a second DbContext Pooling TOC item... |
|
There's going to be many more pages. As soon as I write them. :-) I think just move the second TOC item there. |
roji
force-pushed
the
DbContextPoolingTOC
branch
2 times, most recently
from
c0628b8
to
f5a8dea
Compare
roji
force-pushed
the
DbContextPoolingTOC
branch
from
f5a8dea
to
d46194b
Compare
|
@ajcvickers done |
ajcvickers
approved these changes
Jan 4, 2022
roji
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DbContext Pooling used to be a page under Miscellaneous, but was moved to the Advanced Performance Topics page under Performance. A redirection is already in place, but the old TOC entry was left in place.