Use file-scoped namespaces everywhere in samples #3708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also simple to do automatically with Visual Studio 😉 |
|
@roji Do we want to do this? Generally, we want code copied from samples to be usable by people who might not be running the latest of everything. |
|
I'm thinking that at least EF Core 6.0 users have to use the latest SDK anyway, so they'd have to be manually restricting the language version to pre-10 for this to fail... Am doing some ASP.NET minimal API samples where it would be a shame to have to namespace etc. But am OK if you prefer we didn't do this. |
ajcvickers
approved these changes
Mar 2, 2022
roji
force-pushed
the
FileScopedNamespaces
branch
from
a2b61f8
to
3bdd0bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done automatically with Rider (and manually removed changes to migration files).
Note that if we have any code snippets in the conceptual pages which don't reference a region, this would break them (since line numbers will now shift). However, we almost always use regions which wouldn't be affected (since line numbers are relative).