Add docs on stateful context pool #3709
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And rearrange the perf docs a little.
@ajcvickers would appreciate your opinion on the scoped context factory pattern shown - we've had discussions around this in the past. The one problem here is that it's not possible to register the custom Scoped factory as IDbContextFactory in DI, since that's already taken by the Singleton pooling factory (can't have the same service registered in both Scoped and Singleton).
Ideally the Singleton pooling factory wouldn't be registered as IDbContextFactory, but rather e.g. as PooledDbContextFactory; this would allow the scoped one to be registered as IDbContextFactory, and injected where multiple contexts are needed. But to do that, users would need to duplicate functionality out of e.g. EntityFrameworkServiceCollectionExtensions.AddPoolingOptions. Nothing here seems particularly bad/critical, but maybe we could improve it at some point.
Closes #3706