Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update transactions.md #3823

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Update transactions.md #3823

merged 2 commits into from
Apr 19, 2022

Conversation

eersonmez
Copy link
Contributor

Under the 'Share Connection and transaction' section, the 3rd highlight is on the wrong line. Instead of highlighting the UseTransaction, it highlights the opening curly bracket.

Under the 'Share Connection and transaction' section, the 3rd highlight is on the wrong line. Instead of highlighting the `UseTransaction`, it highlights the opening curly bracket.
@roji
Copy link
Member

roji commented Apr 17, 2022

Thanks - but all of the lines referenced here seem to be off-by-one, not just the one you fixed. Do you mind taking care of the others as well?

Per review by @roji, other highlights were also off by 1 line. Fixed other lines as well.
@eersonmez
Copy link
Contributor Author

@roji Sure thing. Fixed those other lines as well. The first line (new SqlConnection) also seemed relevant to be highlighted so kept that highlighted.

Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants