Initial JSON columns sample #3991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
force-pushed
the
JsonAndTheArgunauts0821
branch
from
3e059c4 to
2ff9578
Compare
maumar
reviewed
Aug 25, 2022
maumar
reviewed
Aug 25, 2022
| Console.WriteLine(); | ||
|
|
||
| // Since query below cannot use Include | ||
| // Issue: https://github.com/dotnet/efcore/issues/28808 |
There was a problem hiding this comment.
Will update in the next PR.
maumar
reviewed
Aug 25, 2022
ajcvickers
force-pushed
the
JsonAndTheArgunauts0821
branch
from
2ff9578 to
fccf6e3
Compare
|
@dotnet/efteam Can someone approve this so I can merge and rebase more recent work on it? Will make requested changes in the next update to this area. |
roji
approved these changes
Aug 25, 2022
| ```sql | ||
| SELECT [a].[Id], [a].[Name], JSON_QUERY([a].[Contact],'$') | ||
| FROM [Authors] AS [a] | ||
| WHERE CAST(JSON_VALUE([a].[Contact],'$.Address.City') AS nvarchar(max)) = N'Chigley' |
There was a problem hiding this comment.
Hmm... Are we sure that we need to systematically add the CAST to nvarchar(max) everywhere where we do JSON_VALUE? At least in this case (and below) that doesn't seem necessary. In other words,
/cc @maumar
There was a problem hiding this comment.
Opened dotnet/efcore#28881 to track this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.