Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove warnings #3993

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Remove warnings #3993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions entity-framework/index.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,11 +41,11 @@ highlightedContent:
# Card
- title: "API reference browser"
itemType: reference
url: /dotnet/api/?view=efcore-6.0
url: /dotnet/api/?view=efcore-6.0&preserve-view=true
# Card
- title: "Explore other options for .NET Data"
itemType: reference
url: dotnet-data
url: dotnet-data/index.yml
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file needs exact file URL. Earlier it was the folder. Which in web world, tries to go to index.* and it worked by accident.


# Card with summary style
additionalContent:
Expand Down
4 changes: 2 additions & 2 deletions entity-framework/toc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,7 @@
href: core/cli/services.md

- name: EF Core API reference >>
href: /dotnet/api/?view=efcore-6.0
href: /dotnet/api/?view=efcore-6.0&preserve-view=true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They recommend not using the version in URL string so it can go to latest by default but since it is a shared docset there is no way for us to specify efcore without using the version (monikers are tied to version). So the later arg explicitly state that we want 6.0 version and don't generate warning.


- name: Entity Framework 6
items:
Expand Down Expand Up @@ -720,4 +720,4 @@
- name: Russian
href: ef6/resources/licenses/ef6/rus.md
- name: EF6 API reference >>
href: /dotnet/api/?view=entity-framework-6.2.0
href: /dotnet/api/?view=entity-framework-6.2.0&preserve-view=true