Finish What's New in EF7 #4076
Merged
Finish What's New in EF7 #4076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
force-pushed
the
PrettyPrettyGoodButNotAsGoodAsLego1008
branch
from
fc5f667 to
6f89ed2
Compare
roji
approved these changes
Oct 10, 2022
| --> | ||
| [!code-csharp[CompositePrimaryKey](../../../../samples/core/Miscellaneous/NewInEFCore7/ModelBuildingSample.cs?name=CompositePrimaryKey)] | ||
|
|
||
| Defining the index on the class also means it can be used to specify private properties or fields as keys, even though these would usually be ignored when building the EF model. For example: |
There was a problem hiding this comment.
Huh, didn't know we didn't support [Key] on private properties/fields... Any specific reason for that?
There was a problem hiding this comment.
We do...but only if the member is already mapped. It won't cause it to be mapped.
There was a problem hiding this comment.
Should we consider enabling this (i.e. mapping the member because it has [Key] on it)? Or would that potentially map something unwanted (because [Key] is being used for some other non-EF framework)?
There was a problem hiding this comment.
Yes, and yes. :-D I made a note to file an issue; it's something I have been thinking about for a while, and something that Diego had ideas on.
Co-authored-by: Shay Rojansky <roji@roji.org>
Co-authored-by: Shay Rojansky <roji@roji.org>
Co-authored-by: Shay Rojansky <roji@roji.org>
Co-authored-by: Shay Rojansky <roji@roji.org>
Co-authored-by: Shay Rojansky <roji@roji.org>
Co-authored-by: Shay Rojansky <roji@roji.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.