Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update commit-failures.md #4225

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Update commit-failures.md #4225

merged 1 commit into from
Jan 26, 2023

Conversation

ricardodsanchez
Copy link
Contributor

Fixed typo

Verified

This commit was signed with the committer’s verified signature.
sdstolworthy Spencer Stolworthy
Fixed typo
@roji
Copy link
Member

roji commented Jan 25, 2023

It seems that both acknowledgment and acknowledgement are valid variants (e.g. Merriam Webster).

@ricardodsanchez
Copy link
Contributor Author

@roji The English version is acknowledgment while the other is British. Since the rest of the text uses the English version, shouldn't all be consistent?

@roji
Copy link
Member

roji commented Jan 26, 2023

The English version is acknowledgment while the other is British.

Do you mean American? 🤣

I don't have any objection to making this change, but out of personal curiosity, can you point to a dictionary talking about this distinction as a dialect thing?

@ricardodsanchez
Copy link
Contributor Author

Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Merging this, hopefully I don't get in trouble with @ajcvickers 😨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants