What's new in EF8 Preview 4 #4346
Conversation
| @@ -1127,3 +1127,468 @@ In addition to the enhancements described above, EF8 Preview 2 also includes som | |||
|
|
|||
| - [Configuration to opt out of occasionally problematic SaveChanges optimizations](https://github.com/dotnet/efcore/issues/29916) | |||
| - [Add convention types for triggers](https://github.com/dotnet/efcore/issues/28687) | |||
|
|
|||
| ## New in EF8 Preview 4 | |||
There was a problem hiding this comment.
Should we just have a flat list, do we think it matters which features were introduced in which preview?
There was a problem hiding this comment.
Not sure. We should discuss.
| .Entity<PrimitiveCollections>() | ||
| .Property(e => e.Booleans) | ||
| .HasMaxLength(1024) | ||
| .IsUnicode(false); |
There was a problem hiding this comment.
Maybe consider not showing IsUnicode(false).. I get that we want to show facet config in general, but some people may copy paste the whole thing or think that it's somehow needed for max length
There was a problem hiding this comment.
Doesn't it make sense to not use Unicode for a JSON list of bool values?
There was a problem hiding this comment.
For bools (non-strings in general) yeah, you're right - it's just that before you discuss only the max length part. Ok with it as-is as well.
|
|
||
| #### Primitive collections in JSON documents | ||
|
|
||
| In all the examples above, column for primitive collection contains JSON. However, this is not the same as mapping [an owned entity type to a column containing a JSON document](xref:core/what-is-new/ef-core-7#json-columns), which was introduced in EF7. But what if that JSON document itself contains a primitive collection? Well, all the queries above still work in the same way! For example, imagine we move the _days visited_ data into an owned type `Visits` mapped to a JSON document: |
There was a problem hiding this comment.
Yeah, the below works but we don't really support this properly 😬 Since the primitive array is encoded as a string within the owned JSON document, some stuff doesn't work correctly. It may be worth at least mentioning this problem (and maybe even leave this section out until we fix this)
There was a problem hiding this comment.
Will merge for now, and we can discuss. I was impressed that all the queries I tried actually worked. Hopefully nobody looks at the actual JSON. ;-)
Primitive collections
Co-authored-by: Shay Rojansky <roji@roji.org>
Co-authored-by: Shay Rojansky <roji@roji.org>
Co-authored-by: Shay Rojansky <roji@roji.org>
ajcvickers
force-pushed
the
OffOrOnOrOnOrOffOrOn0427
branch
from
6c59ff4 to
3385036
Compare
Primitive collections