Skip to content

Cosmos full-text search "what's new" docs #5009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025
Merged

Conversation

maumar
Copy link
Contributor

@maumar maumar commented Apr 18, 2025

What's new docs for dotnet/efcore#35476

@maumar maumar requested review from roji and jamesmontemagno April 18, 2025 06:52
@maumar maumar force-pushed the whats_new_preview4 branch 2 times, most recently from c82746d to 53abadb Compare April 18, 2025 07:19
@maumar maumar requested a review from a team April 18, 2025 07:21
@SamMonoRT
Copy link
Member

LGTM - what are the lint markdown failures?

@SamMonoRT SamMonoRT requested a review from Pilchie April 18, 2025 13:49
@maumar
Copy link
Contributor Author

maumar commented Apr 18, 2025

@SamMonoRT #5010

@maumar maumar force-pushed the whats_new_preview4 branch 3 times, most recently from f0d5759 to 3948017 Compare April 18, 2025 18:56
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks pretty good. Note that we also need to document this in the Cosmos docs, not just in "what's new", I'm a believer in doing both at the same time - this way the what's new can be relatively minimal, and link to the full docs.

@roji roji changed the title full-text search docs Cosmos full-text search docs Apr 19, 2025
@roji roji changed the title Cosmos full-text search docs Cosmos full-text search "what's new" docs Apr 19, 2025
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maumar, starting to look pretty good - see below for remaining comments.

@maumar maumar force-pushed the whats_new_preview4 branch 2 times, most recently from 6e20070 to f3e9416 Compare April 22, 2025 10:54
@maumar
Copy link
Contributor Author

maumar commented Apr 22, 2025

updated @roji

Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maumar, looks great.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Added note about vector search going out of preview
Updated the vector search docs as well
@maumar maumar force-pushed the whats_new_preview4 branch from f3e9416 to b8cfcbe Compare April 22, 2025 18:27
@SamMonoRT
Copy link
Member

@jamesmontemagno @roji - is this good to go given P4 was released?

@richlander
Copy link
Member

Yes. Can we merge it?

@richlander
Copy link
Member

Merging to keep the process going and to help out other teams who want to reference this content. We can adjust after the fact

@richlander richlander merged commit cb3ccc6 into main May 16, 2025
4 checks passed
richlander added a commit that referenced this pull request May 16, 2025
Added note about vector search going out of preview
Updated the vector search docs as well

Co-authored-by: Maurycy Markowski <maumar@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants