Cake Addin for getting Nerdbank.GitVersioning VersionOracle. #171
Conversation
|
I'm currently working on addressing these build failures. Will report back. #Closed |
|
Sorry for the delay in getting the build issues addressed. #Closed |
Also don't require explicit acceptance of the license
AArnott
left a comment
AArnott
left a comment
There was a problem hiding this comment.
I've made several changes. Can you validate using cake that the built package still works?
| <PackageLicenseUrl>https://raw.githubusercontent.com/AArnott/Nerdbank.GitVersioning/39ac76891c/LICENSE.txt</PackageLicenseUrl> | ||
| <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance> | ||
| <PackageProjectUrl>http://github.com/aarnott/Nerdbank.GitVersioning</PackageProjectUrl> | ||
| <SignAssembly>false</SignAssembly> |
There was a problem hiding this comment.
Did signing mess anything up? Otherwise, I'd prefer we sign it. #Closed
There was a problem hiding this comment.
I see... Cake.Core itself isn't strong name signed. #Closed
There was a problem hiding this comment.
Yeah, I initially attempted to sign the assembly, but also discovered that Cake.Core was not signed. I would be willing to submit an issue to the Cake team to see if they'd be willing to strong name sign Cake.Core. I am unsure if that would affect anything down stream of them though. #Closed
There was a problem hiding this comment.
It probably would impact their existing users. And my guess for a package that popular is that if they're not signed, they probably are opposed to the idea. It's OK. We can fall in line for the cake plugin. #Closed
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Cake.Core" Version="0.26.0" /> | ||
| <PackageReference Include="Nerdbank.GitVersioning.LKG" Version="1.6.20-beta-gfea83a8c9e" /> |
There was a problem hiding this comment.
I've modified both of these to suppress the dependency #Closed
|
@clcrutch Can you confirm that the package we're building after my changes to your PR works? #Closed |
|
Also, can you update the docs in this repo to include something about this feature? #Closed |
|
@AArnott I just confirmed that the changes still work after your changes. I'll update the docs to include information about this feature and let you know when I am finished. #Closed |
|
I've added docs. There are a few mistakes I'm working on correcting. #Closed |
|
I've updated the docs. I think I'm content with them. I'd love some feedback though. #Closed |
|
I'm not sure why the build failed. The build failure appears to happen after it has already built my code. It also builds fine on my end.
|
|
All builds now pass. #Closed |
|
Sorry about the noise. Was reviewing the pull request and accidentally closed the PR. Otherwise, I think I'm content with the changes here. Is there anything else that I should do on my end? Edit: fixed the build errors again, so the statement above is true once more. #Closed |
|
Great. I just got back from a vacation where I had no Internet access, so I'm catching up. I look forward to reviewing this again and merging. #Closed |
|
Why are all these markdown files that describe the public API checked into source? If they were generated, they need to be generated during the build--not as a once off plus checkin. Otherwise it becomes a maintenance nightmare. Can that be done? |
|
(just to be clear, when I asked for documentation I was only asking for the |
| EndProject | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "nbgv", "nbgv\nbgv.csproj", "{EF4DAF23-6CE9-48C5-84C5-80AC80D3D07D}" | ||
| Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Cake.GitVersioning", "Cake.GitVersioning\Cake.GitVersioning.csproj", "{1F267A97-DFE3-4166-83B1-9D236B7A09BD}" | ||
| EndProject |
There was a problem hiding this comment.
It looks like you resolved a merge conflict by blowing away the competing addition. I need nbgv to stick around. :) #Closed
There was a problem hiding this comment.
src/Nerdbank.GitVersioning.sln.orig
Outdated
| @@ -0,0 +1,84 @@ | |||
| | |||
| Microsoft Visual Studio Solution File, Format Version 12.00 | |||
There was a problem hiding this comment.
This file doesn't belong here. #Closed
There was a problem hiding this comment.
2 participants
Cake Addin for getting Nerdbank.GitVersioning VersionOracle.
This is a cake addin for getting the VersionOracle for the current git repo.
Fixes #148