-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "prepare-release" command #291
Conversation
…t consistent with the rest of the code base
Before this change, although the version file was committed, git thought the file was both added to the index and deleted locally. By useing Stage, the working directory is in a clean state after CommitVersionFile()
… master branch's version
… on the release branch
…dout and stderr text writers
When incrementing major or minor version, set following version components to 0
…ions are read from version.json correctly
…s branch name setting
…so a signature can be built even if the user name and email are not configured on the repo-level
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much. You're clearly meticulous with error and edge cases. Awesome!
I'm preparing a few changes locally that I'll push to your branch. But I do have one question for you.
Also adjust test to assert that {0} is not a valid placeholder.
I just tried this command out in one of my repos. There were two issues:
We must fix the |
I've fixed the |
This stops us from commiting a change that just changes trivia in the file.
Also decreased message verbosity to STDOUT
Bumps [xunit](https://github.com/xunit/xunit) from 2.9.1 to 2.9.2. - [Commits](xunit/xunit@v2-2.9.1...v2-2.9.2) --- updated-dependencies: - dependency-name: xunit dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This PR adds the
prepare-release
command as discussed in #287I made a minor modification to the feature compared to what was discussed in the issue. The setting to control the name of release branches does not use
{0}
as a placeholder for the version but{version}
. I think this makes it more consistent with the version setting which uses{height}
Closes #287