Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepend version source file to compile file list #309

Merged
merged 1 commit into from
Mar 19, 2019

Conversation

ctaggart
Copy link
Contributor

@ctaggart ctaggart commented Mar 19, 2019

fix #308. Code from there too, except for one $ to a @.

Tested locally by modifying in place:
"C:\Users\taggac.nuget\packages\nerdbank.gitversioning\2.3.136\build\Nerdbank.GitVersioning.targets"

    <Message Text="Compile Items Before" Importance="high" />
    <Message Text="@(Compile)" Importance="high" />
    <ItemGroup>
      <_CompileWithVersionFile Include="$(VersionSourceFile);@(Compile)" />
      <Compile Remove="@(Compile)" />
      <Compile Include="@(_CompileWithVersionFile)" />
      <_CompileWithVersionFile Remove="@(_CompileWithVersionFile)" />
    </ItemGroup>
    <Message Text="Compile Items After" Importance="high" />
    <Message Text="@(Compile)" Importance="high" />

Everything compile correctly and I saw this like I was expecting:

       GenerateAssemblyVersionInfo:
         Compile Items Before
         Ast.fs;Parser.fs;ClassModel.fs
         Compile Items After
         obj\Debug\netstandard2.0\\Froto.Parser.Version.fs;Ast.fs;Parser.fs;ClassModel.fs
   1:2>Project "C:\Users\taggac\github\froto\Froto.sln" (1:2) is building "C:\Users\taggac\github\froto\Compiler\Froto.Compiler.fsproj" (3:6) on node 5 (default targets).
     3>GetBuildVersion:
         Building version 0.6.4.62844 from commit 7cf54c4eb8adb025047f63f74f72db2b9204a8c0
       GenerateAssemblyVersionInfo:
         Compile Items Before
         Program.fs
         Compile Items After
         obj\Debug\netcoreapp2.1\\Froto.Compiler.Version.fs;Program.fs

Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching my bug and fixing this, and testing it!

@AArnott AArnott merged commit 6d930a1 into dotnet:master Mar 19, 2019
@ctaggart ctaggart deleted the fsharp-exe branch March 19, 2019 22:57
AArnott added a commit that referenced this pull request Dec 8, 2024
Workaround github's protections for workflow changes in GitHub Actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

F# exe projects fail because EntryPointAttribute attribute must be the last file
2 participants