Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UsePipe: Completing reader and writer does not dispose PipeStream on .NET Framework #162

Closed
AArnott opened this issue Feb 8, 2020 · 0 comments
Closed

UsePipe: Completing reader and writer does not dispose PipeStream on .NET Framework #162

AArnott opened this issue Feb 8, 2020 · 0 comments
Assignees
@AArnott
Labels
bug
Milestone
v2.4

Comments

@AArnott
Copy link
Collaborator

AArnott commented Feb 8, 2020

When a PipeStream is passed to the UsePipe extension method, completing the returned PipeReader and PipeWriter will not usually dispose of the underlying pipe when on .NET Framework.

See also: dotnet/runtime#31390

.NET Framework does not honor the CancellationToken passed to PipeStream.ReadAsync once the async I/O has been requested.
AArnott added a commit that referenced this issue Feb 8, 2020
@AArnott
Add test for disposing of a PipeStream wrapped in an IDuplexPipe
46f0ae0 
This repros #162
@AArnott AArnott added the bug label Feb 8, 2020
@AArnott AArnott self-assigned this Feb 8, 2020
@AArnott AArnott added this to the v2.4 milestone Feb 8, 2020
AArnott added a commit that referenced this issue Feb 8, 2020
@AArnott
Add test for disposing of a PipeStream wrapped in an IDuplexPipe
fb0f765 
This repros #162
AArnott added a commit that referenced this issue Feb 8, 2020
@AArnott
Dispose Stream even when Stream.ReadAsync does not honor Cancellation…
a84bbe6 
…Token

`PipeStream.ReadAsync` does not honor `CancellationToken` on .NET Framework.
This change works around this limitation by calling `Stream.Dispose()` when we're sure that the UsePipe front-end user is done using it, which causes the ReadAsync call to complete.

Fixes #162
@AArnott AArnott mentioned this issue Feb 8, 2020
Merged
@AArnott AArnott closed this as completed Feb 9, 2020
@AArnott AArnott mentioned this issue Feb 10, 2020
Merged
AArnott added a commit that referenced this issue Jun 20, 2022
@AArnott
Merge pull request #162 from AArnott/fix161
a4496aa 
Include only unique coverage reports in artifact
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AArnott AArnott

Labels
bug
Projects
None yet
Milestone
v2.4
Development

No branches or pull requests
1 participant
@AArnott