Fix symbol check for insertion #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this so insertion PR can be kicked off. |
adamint
pushed a commit
that referenced
this pull request
Sep 24, 2024
Fix symbol check for insertion
adamint
pushed a commit
that referenced
this pull request
Sep 24, 2024
Fix symbol check for insertion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The symbol check was failing for insertions after my previous change to add SBOM. I had a hunch that it was because I wasn't cleaning the artifacts after I do the quick build to generate SBOM. This seems to have worked as now symbol check has passed.
Successful draft insertion: https://devdiv.visualstudio.com/DevDiv/_git/VS/pullrequest/389567