Issue1069 check for model/gltf.binary content type and accept

[tomjebo]

This fix checks to see if the part content type is "model/gltf.binary" and the expected part is "model/gltf-binary". If so, then the SDK accepts the part as is. Both will be consumed but the SDK will continue to write out "model/gltf-binary" as this is the current standard and is accepted by PowerPoint.

[tomjebo]

Fixes #1069

[sergey-tihon]

@tomjebo would be nice to have test for this case in the repo ;)

I build SDK from this branch and confirm that it works on my files.

[twsouthwick]

Don't forget to update the changelog

[twsouthwick]

Can you add a test for this?

[twsouthwick]

Not sure the current override will do what you're expecting. It would be great to have a test for this.

[twsouthwick]

A couple comments, but do with them as you want. Once you've addressed the warnings, feel free to merge!

[twsouthwick]

Can these be separate tests? Also, it would nice to assert on the content type of the package

[tomjebo]

@twsouthwick not sure what you mean by "content type of the package". Do you mean assert on the model/gltf-binary content type (the part) or do you mean something else? The test is pretty much about validating the model/gltf(-|.)binary content type so I don't know why it should explicitly assert this. Maybe you mean assert that the glb part is not something else?

[twsouthwick]

Because then when you look at the test, you know that is what you're testing here. In a year, or 5 years, you may not remember exactly what the test is supposed to be doing

[tomjebo]

what i meant was, there is no content type of the package. do you mean assert on the content type of the .glb part? If so, I can probably add code to find the part and check that it's either model/gltf-binary or model/gltf.binary. But we say that in the comments and the code will assert that naturally.

[tomjebo]

But I can see what you mean. It's not clear what the test is actually looking for other than a clean open with a non-null package object. I'll add some code to look for the part and see if it's one of the two.

[tomjebo]

Actually, it will have to be model/gltf-binary. The part class (Model3DReferenceRelationshipPart) will always show as model/gltf-binary internally and will write this (when a new one is created). But will just look the other way when loading model/glft.binary. I added the assert for it.