Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding new package icon #377

Merged
merged 2 commits into from
Jan 6, 2018
Merged

adding new package icon #377

merged 2 commits into from
Jan 6, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jan 5, 2018

Added the following element to DocumentFormat.OpenXml.Package.Props:

<PackageIconUrl>https://raw.githubusercontent.com/OfficeDev/Open-XML-SDK/master/icon.png</PackageIconUrl>

Added the vector graphic source file and the png for the icon.

  • icon.svg
  • icon.png

@twsouthwick
Copy link
Member

What's the resolution of png? It needs to be 64x64 for NuGet

@ghost
Copy link
Author

ghost commented Jan 5, 2018

@twsouthwick the png is precisely 64 pixels by 64 pixels.

@twsouthwick twsouthwick self-requested a review January 5, 2018 23:36
icon.svg Outdated
id="svg11519"
inkscape:version="0.92.2 (5c3e80d, 2017-08-06)"
sodipodi:docname="ooxml_sdk_icon_20.svg"
inkscape:export-filename="D:\OneDrive - Microsoft\Open XML SDK\ooxml icons\ooxml_sdk_icon_20.png"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want this in there?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, @twsouthwick. No, I don't want that in there. I updated it with a clean svg.

@tomjebo tomjebo merged commit f2ff2ba into dotnet:master Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants