Use marshalling to load constraint data #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of reading byte by byte, we can just load the entire structure at a single time since all the objects are structs and have simple data types. This provides a good performance help and allows for easier updates to the data structures without needing to manually rework the serialization and deserialization methods
twsouthwick
force-pushed
the
marshalling
branch
from
0228f97 to
09f95cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of reading byte by byte, we can just load the entire structure
at a single time since all the objects are structs and have simple data
types. This provides a good performance help and allows for easier
updates to the data structures without needing to manually rework the
serialization and deserialization methods