OnExecute: log inner exceptions (#1751)

* OnExecute: log inner exceptions

Log the whole exception chain when an exception gets caught by a program.

* typo fix

* ActionInvoker: use chained exceptions

* CodeGenCommand.Execute: log inner exceptions

src/Scaffolding/VS.Web.CG.Core/ActionInvoker.cs

@@ -56,7 +56,7 @@ internal void BuildCommandLine(CommandLineApplication command)
  }
  catch (Exception ex)
  {
- throw new InvalidOperationException(string.Format(MessageStrings.ModelCreationFailed, ex.Message));
+ throw new InvalidOperationException(string.Format(MessageStrings.ModelCreationFailed, ex.Message), ex);
  }
 
  foreach (var param in ActionDescriptor.Parameters)

src/Scaffolding/VS.Web.CG.Design/Program.cs

@@ -90,14 +90,18 @@ private static void Execute(string[] args, ConsoleLogger logger)
  }
  catch(Exception ex)
  {
- logger.LogMessage(Resources.GenericErrorMessage, LogMessageLevel.Error);
- logger.LogMessage(ex.Message, LogMessageLevel.Error);
- logger.LogMessage(ex.StackTrace, LogMessageLevel.Trace);
- if (!logger.IsTracing)
+ do
  {
- logger.LogMessage(Resources.EnableTracingMessage);
+ logger.LogMessage(Resources.GenericErrorMessage, LogMessageLevel.Error);
+ logger.LogMessage(ex.Message, LogMessageLevel.Error);
+ logger.LogMessage(ex.StackTrace, LogMessageLevel.Trace);
+ if (!logger.IsTracing)
+ {
+ logger.LogMessage(Resources.EnableTracingMessage);
+ }
+ ex = ex .InnerException;
  }
-
+ while (!(ex is null));
  }
  return exitCode;
  

src/Scaffolding/VS.Web.CG/CodeGenCommand.cs

@@ -50,12 +50,17 @@ public int Execute(string [] args)
  }
  catch (Exception ex)
  {
- while (ex is TargetInvocationException)
+ do
  {
+ while (ex is TargetInvocationException)
+ {
+ ex = ex.InnerException;
+ }
+ _logger.LogMessage(ex.Message, LogMessageLevel.Error);
+ _logger.LogMessage(ex.StackTrace);
  ex = ex.InnerException;
  }
- _logger.LogMessage(ex.Message, LogMessageLevel.Error);
- _logger.LogMessage(ex.StackTrace);
+ while (ex is Exception);
  }
  return 0;
  }