Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split register-application command #1544

Merged
merged 2 commits into from
Apr 5, 2021
Merged

split register-application command #1544

merged 2 commits into from
Apr 5, 2021

Conversation

deepchoudhery
Copy link
Member

@deepchoudhery deepchoudhery commented Apr 5, 2021 •
edited
Loading

Changes for MsIdentity :
split register-application into

  • register-app --> registers app registration in Azure.
  • update-app --> updates app registration in Azure
  • unregister-app --> unregisters app registration in Azure
  • update-project --> Updates Startup.cs, appsettings.json, and whatever project files that need updating.

Currently, register, and update are exactly the same. Update coming soon.

Also updated MsIdentity package versions to 1.0.0-preview.1.XXXX.

@deepchoudhery deepchoudhery self-assigned this Apr 5, 2021
@deepchoudhery deepchoudhery merged commit 6d37285 into main Apr 5, 2021
@deepchoudhery deepchoudhery deleted the dev/decho/splitCommands branch April 6, 2021 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijayrkn vijayrkn vijayrkn approved these changes

@sayedihashimi sayedihashimi Awaiting requested review from sayedihashimi

@abpiskunov abpiskunov Awaiting requested review from abpiskunov

@phil-allen-msft phil-allen-msft Awaiting requested review from phil-allen-msft

@zahalzel zahalzel Awaiting requested review from zahalzel

Assignees

@deepchoudhery deepchoudhery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepchoudhery @vijayrkn