Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added --add-client-secret and --update-app-registration #1557

Merged
merged 7 commits into from
Apr 22, 2021
Merged

Added --add-client-secret and --update-app-registration #1557

merged 7 commits into from
Apr 22, 2021

Conversation

deepchoudhery
Copy link
Member

@deepchoudhery deepchoudhery commented Apr 21, 2021 •
edited
Loading

Added 2 commands

  • add-client-secret
    • Create a client secret, add it to the Azure AD app registration.
  • update-app-registration
    • Update Azure AD app registrations with redirect URLs

@deepchoudhery deepchoudhery changed the title Added --add-user-secrets and --update-app-registration Added --add-client-secret and --update-app-registration Apr 21, 2021
@deepchoudhery deepchoudhery self-assigned this Apr 21, 2021
jmprieur
jmprieur reviewed Apr 22, 2021
View reviewed changes
Copy link

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've a few suggestions and questions.

...t.DotNet.MSIdentity/MicrosoftIdentityPlatform/MicrosoftIdentityPlatformApplicationManager.cs Outdated Show resolved Hide resolved
src/MSIdentityScaffolding/Microsoft.DotNet.MSIdentity/Tool/ProvisioningToolOptions.cs Show resolved Hide resolved
tools/dotnet-msidentity/Program.cs Show resolved Hide resolved
tools/dotnet-msidentity/Program.cs Outdated Show resolved Hide resolved
@deepchoudhery deepchoudhery merged commit 31074fd into main Apr 22, 2021
@deepchoudhery deepchoudhery deleted the dev/decho/secretsUpdate branch April 22, 2021 20:29
@deepchoudhery deepchoudhery mentioned this pull request Apr 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmprieur jmprieur jmprieur left review comments

@phil-allen-msft phil-allen-msft phil-allen-msft approved these changes

@vijayrkn vijayrkn Awaiting requested review from vijayrkn

@zahalzel zahalzel Awaiting requested review from zahalzel

Assignees

@deepchoudhery deepchoudhery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepchoudhery @jmprieur @phil-allen-msft