Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added create-app-registration command #1564

Merged
merged 4 commits into from
Apr 27, 2021
Merged

added create-app-registration command #1564

merged 4 commits into from
Apr 27, 2021

Conversation

deepchoudhery
Copy link
Member

Initial Draft

  • added --create-app-registration
    • allows to create Azure AD/AD B2C app registrations.
    • TODO : change object being passed back?
  • renamed --add-client-secret --> --create-client-secret
  • added ConsoleLogger to simplify outputting to console when --json is enabled
  • changed --project-path to have path to the .csproj file instead of folder with the .csproj file.
  • added ValidateUrisTest unit test

@deepchoudhery deepchoudhery self-assigned this Apr 27, 2021
@deepchoudhery deepchoudhery requested review from phil-allen-msft and removed request for zahalzel April 27, 2021 23:17
@deepchoudhery deepchoudhery merged commit d24b975 into main Apr 27, 2021
@deepchoudhery deepchoudhery deleted the dev/decho/createAppRegistrationCommand branch April 27, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmprieur jmprieur jmprieur left review comments

@phil-allen-msft phil-allen-msft phil-allen-msft approved these changes

@abpiskunov abpiskunov Awaiting requested review from abpiskunov

@vijayrkn vijayrkn Awaiting requested review from vijayrkn

Assignees

@deepchoudhery deepchoudhery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepchoudhery @jmprieur @phil-allen-msft