Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dotnet-msidentity] help, README, and version update #1569

Merged
merged 2 commits into from
May 11, 2021
Merged

[dotnet-msidentity] help, README, and version update #1569

merged 2 commits into from
May 11, 2021

Conversation

deepchoudhery
Copy link
Member

Update

  • both READMEs in src/tools/dotnet-msidentity and src/MsIdentity (package version in the README as well)
  • help text in src/tools/dotnet-msidentity/Program.cs

@deepchoudhery deepchoudhery self-assigned this May 10, 2021
sayedihashimi
sayedihashimi reviewed May 11, 2021
View reviewed changes
Copy link
Member

@sayedihashimi sayedihashimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments. I'd like to clean up the doc a bit more later. After we get this PR merged, I can take a look and submit a PR for the other changes that I'd like to make.

src/MSIdentityScaffolding/README.md Outdated Show resolved Hide resolved
tools/dotnet-msidentity/dotnet-msidentity.csproj Show resolved Hide resolved
tools/dotnet-msidentity/README.md Outdated Show resolved Hide resolved
src/MSIdentityScaffolding/README.md Outdated Show resolved Hide resolved
src/MSIdentityScaffolding/README.md Show resolved Hide resolved
src/MSIdentityScaffolding/README.md Outdated Show resolved Hide resolved
@deepchoudhery deepchoudhery merged commit b744878 into main May 11, 2021
@deepchoudhery deepchoudhery deleted the dev/decho/helpUpdate branch May 11, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayedihashimi sayedihashimi sayedihashimi approved these changes

@vijayrkn vijayrkn Awaiting requested review from vijayrkn

@jmprieur jmprieur Awaiting requested review from jmprieur

@phil-allen-msft phil-allen-msft Awaiting requested review from phil-allen-msft

Assignees

@deepchoudhery deepchoudhery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepchoudhery @sayedihashimi