Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix position of the Logout button near the profile link #1913

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

jacob-l
Copy link
Contributor

@jacob-l jacob-l commented Jun 5, 2022

The "btn-link" class has 1px border and, as a result, a button looks misplaced.

Before:
Снимок экрана 2022-06-04 в 21 25 36

After:
Снимок экрана 2022-06-05 в 15 51 54

@deepchoudhery deepchoudhery requested a review from HaoK June 6, 2022 23:12
@deepchoudhery
Copy link
Member

@HaoK feedback here pls

@HaoK
Copy link
Member

HaoK commented Jun 6, 2022

Any fixes for code in the scaffolding should go through updating the runtime code first, https://github.com/dotnet/aspnetcore/tree/main/src/Identity/UI/src/Areas/Identity

Can you open a PR against that first @jacob-l

@jacob-l
Copy link
Contributor Author

jacob-l commented Jun 8, 2022

Hi @HaoK , Thank you very much for your assistance. I can not find "_LoginPartial.cshtml" in that folder. However, I have created a new project with .Net 7 Preview 6 and I can see that there is _LoginPartial in the generated project. Where does it take the template?

@deepchoudhery deepchoudhery self-requested a review June 16, 2022 22:15
Copy link
Member

@deepchoudhery deepchoudhery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepchoudhery
Copy link
Member

Hi @HaoK , Thank you very much for your assistance. I can not find "_LoginPartial.cshtml" in that folder. However, I have created a new project with .Net 7 Preview 6 and I can see that there is _LoginPartial in the generated project. Where does it take the template?

thanks a lot, looks good.
Appreciate the fix.

Thanks,
Deep

@deepchoudhery deepchoudhery merged commit 1255829 into dotnet:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants