Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

not adding extra whitespace and checking for Main method correctly #2013

Merged
merged 1 commit into from
Sep 8, 2022
Merged

not adding extra whitespace and checking for Main method correctly #2013

merged 1 commit into from
Sep 8, 2022

Conversation

deepchoudhery
Copy link
Member

@deepchoudhery deepchoudhery commented Sep 7, 2022 •
edited
Loading

  • not adding extra whitespace when using top level statements.
  • checking FileScopedNamespace and regular Namespace for finding methods in GetMethodFromSyntaxRoot
    • adding extra logic for IsUsingTopLevelStatements

@deepchoudhery deepchoudhery self-assigned this Sep 7, 2022
zahalzel
zahalzel approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@zahalzel zahalzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

@deepchoudhery deepchoudhery merged commit 4bb5a46 into main Sep 8, 2022
@deepchoudhery deepchoudhery deleted the dev/decho/identity-formatting-fix branch September 8, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zahalzel zahalzel zahalzel approved these changes

Assignees

@deepchoudhery deepchoudhery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepchoudhery @zahalzel