minimal api net7 changes #2046

deepchoudhery · 2022-10-12T20:11:42Z

Addressing changes from #2037.

Update non-EF Core scaffolder to also use TypedResults

the non-EF scaffolder has commented out the Results return so just have changed it TypedResults but still commented out.

src/Scaffolding/VS.Web.CG.Mvc/Templates/MinimalApi/MinimalApi.cshtml

DamianEdwards · 2022-10-14T23:07:05Z

Are you we planning on adding the option for TypedResults as discussed in the issue?

deepchoudhery · 2022-10-18T08:25:56Z

Are you we planning on adding the option for TypedResults as discussed in the issue?

Yep, that'll be in the next PR and that will have VS work alongside it. Won't be closing the issue for now.

deepchoudhery requested review from DamianEdwards and vijayrkn October 12, 2022 20:11

deepchoudhery self-assigned this Oct 12, 2022

deepchoudhery added 2 commits October 12, 2022 14:59

minor changes.

55d1ecb

added TypedResults for non ef endpoitns scenario.

004fabb

deepchoudhery force-pushed the dev/decho/minimal-api-net7-changes branch from 462bdb5 to 004fabb Compare October 12, 2022 22:08

DamianEdwards reviewed Oct 14, 2022

View reviewed changes

src/Scaffolding/VS.Web.CG.Mvc/Templates/MinimalApi/MinimalApi.cshtml Outdated Show resolved Hide resolved

flipped group calls to alphabetize them.

cc5c2bb

DamianEdwards self-requested a review October 18, 2022 15:55

DamianEdwards approved these changes Oct 18, 2022

View reviewed changes

deepchoudhery merged commit b332151 into main Oct 18, 2022

deepchoudhery deleted the dev/decho/minimal-api-net7-changes branch October 18, 2022 19:47

Provide feedback