Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add/edit paths where we look for dotnet sdk. #2957

Merged
merged 2 commits into from
Oct 30, 2024
Merged

add/edit paths where we look for dotnet sdk. #2957

merged 2 commits into from
Oct 30, 2024

Conversation

deepchoudhery
Copy link
Member

@deepchoudhery deepchoudhery commented Sep 6, 2024 •
edited
Loading

incorrect paths were being checked for both mac and linux. For mac, the ARM path was not being checked. For linux, the path being checked was wrong.

  • added the correct linux default path.
  • added the correct path to look in macOS for the ARM .NET SDK. Check for this before an x64 version of the sdk because macOS is ARM based now (and x64 will eventually be deprecated)

@deepchoudhery deepchoudhery self-assigned this Sep 6, 2024
tlmii
tlmii approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@tlmii tlmii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it odd that linux can have so many possible "standard" install locations, but that's just something we have to deal with, not something we can change.

@deepchoudhery deepchoudhery marked this pull request as draft September 6, 2024 18:36
@deepchoudhery
Copy link
Member Author

I find it odd that linux can have so many possible "standard" install locations, but that's just something we have to deal with, not something we can change.

I did not dig deep enough potentially so will get this tested more and update this after

@deepchoudhery deepchoudhery force-pushed the dev/decho/edit-checked-sdk-paths branch from 4330b14 to 1a3fade Compare October 30, 2024 03:37
@deepchoudhery deepchoudhery marked this pull request as ready for review October 30, 2024 03:38
@deepchoudhery deepchoudhery enabled auto-merge (squash) October 30, 2024 03:44
@deepchoudhery deepchoudhery merged commit 0ca514b into main Oct 30, 2024
8 checks passed
@deepchoudhery deepchoudhery deleted the dev/decho/edit-checked-sdk-paths branch October 31, 2024 19:35
@deepchoudhery
Copy link
Member Author

/backport to release/9.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

Started backporting to release/9.0: https://github.com/dotnet/Scaffolding/actions/runs/11636755182

@github-actions github-actions bot mentioned this pull request Nov 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlmii tlmii tlmii approved these changes

Assignees

@deepchoudhery deepchoudhery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepchoudhery @tlmii