Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update identity scaffolding dependency content #2963

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Update identity scaffolding dependency content #2963

merged 2 commits into from
Sep 23, 2024

Conversation

MackinnonBuck
Copy link
Member

@MackinnonBuck MackinnonBuck commented Sep 13, 2024 •
edited
Loading

Updates dependencies of the "Bootstrap4" and "Bootstrap5" variants of Identity MVC scaffolding. This PR also adds new NPM scripts to make the dependency update process easier.

Validated the changes locally by installing and running the aspnet-codegenerator tool:
image

@MackinnonBuck MackinnonBuck marked this pull request as ready for review September 13, 2024 22:32
deepchoudhery
deepchoudhery approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@deepchoudhery deepchoudhery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! will be creating dotnet-scaffold identity scaffolder soon as well! will add you to that PR for content check tyty.

@MackinnonBuck MackinnonBuck merged commit 240ba78 into main Sep 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiercn javiercn javiercn left review comments

@deepchoudhery deepchoudhery deepchoudhery approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MackinnonBuck @javiercn @deepchoudhery